Fix panel sometimes being behind windows #2094
Conversation
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
This fixes the issue with the Dock, but not if you log in -> open maximized window using Super + number -> press Super to open Applications menu, this results in application menu being below maximized window. I guess we need to apply the same fix somewhere else in the code?
|
Yeah probably I'm just not sure where would be best. I guess we should connect to some event but which? We could do focus on the window but that only works because we know the wingpanel implementation and that it requests focus every time it goes out of it's reserved space 🤷 |
|
I have no idea either. I think we should add // FIXME here and just merge it. We can fix wingpanel issue later as it's not critical. |
|
Note that even on "stock" Horus (and nothing compiled from source) the application menu is behind maximized windows, so it's not a new issue and not related to new changes |
I did that now so it updates visible on focused which should fix the wingpanel issue for now |
Hmm I don't remember that. Maybe you mean fullscreen windows so that wingpanel isn't visible at all? |
Oh yes I mean fullscreen, when wingpanel isn't visible. Then if I press Super + space to open the application menu, it opens behind the window (I can search and launch apps via the keyboard). Doesn't happen if the app is just maximized and wingpanel is still visible, in that case the application menu appears above the window. Got a little confused by the terms, sorry |
Fixes #2080